-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report Connection Level Fracturing Statistics to I/O Layer #5811
Draft
bska
wants to merge
15
commits into
OPM:master
Choose a base branch
from
bska:report-conn-level-fracture-statistics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am creating this PR in draft mode for two reasons
|
bska
force-pushed
the
report-conn-level-fracture-statistics
branch
from
December 18, 2024 14:10
72baa03
to
2a0c294
Compare
bska
force-pushed
the
report-conn-level-fracture-statistics
branch
11 times, most recently
from
December 20, 2024 12:05
3b84b33
to
7764476
Compare
…ctures on wells is growing
- added numOverlap to flowgeneric
Not all 'problem's have a geomechanical model, so limit block level stress collection to those that do. While here, also install more headers to enable downstream/out-of-tree users of the main simulator classes. Finally, reduce scope of some objects and be (more) 'const' correct.
In particular, split this function into distinct steps: 1. Computing the linearised IJK index of each connection. 2. Reporting multiplicative factors such as the CTF, the D factor, and the transmissibility multiplier due to rock compaction. 3. Reporting pressures, flow rates, and productivity indices. 4. Reporting filter cake values for injectors While here, also reverse a condition in init() to enable "early continue" and reduce levels of nesting and to reduce scope of some objects.
In particular, * RunningStatistics calculates basic statics measures of a running sample * ConnFracStatistics aggregates those measures for connection level fracture pressure, fracture width, and flow rate
Populates the new data::Connection::fract data member.
bska
force-pushed
the
report-conn-level-fracture-statistics
branch
from
December 20, 2024 14:47
7764476
to
e03ad2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populates the new
data::Connection::fract
data member from PR OPM/opm-common#4388.To this end, introduce two helper classes to compute statistics of a running sample:
RunningStatistics
calculates basic statics measures of a running sampleConnFracStatistics
aggregates those measures for connection level fracture pressure, fracture width, and flow rate